Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test template name handling #603

Merged
merged 8 commits into from Mar 10, 2022
Merged

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Mar 3, 2022

Closes #601

Proposed commit message:

Refactor test template name handling (#601 / #603)

Due to Pioneer having multiple TestTemplate based extensions
the need for a unified TestNameFormatter arose. This PR moves
CartesianTestNameFormatter to the internal package, so it may
be used by other extensions as well.

Closes: #601
PR: #603

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Michael1993 Michael1993 added full-build Triggers full build suite on PR ⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) labels Mar 3, 2022
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nipafx nipafx mentioned this pull request Mar 10, 2022
13 tasks
@nipafx nipafx merged commit ad7736a into main Mar 10, 2022
@nipafx nipafx deleted the issue/601-name-for-retrying-test branch March 10, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add name attribute for @RetryingTest
3 participants