Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct workflow name so build status image is displayed (#530) #531

Merged
merged 4 commits into from Oct 8, 2021
Merged

Correct workflow name so build status image is displayed (#530) #531

merged 4 commits into from Oct 8, 2021

Conversation

johnlehne
Copy link
Contributor

@johnlehne johnlehne commented Oct 8, 2021 •
edited 

Fix build status image (#530 / #531)

Corrected the path to the GitHub workflow build status.

Closes: #530 
PR: #531

Test:
image

@johnlehne johnlehne changed the title Correct the workflow name so build status image is displayed Correct the workflow name so build status image is displayed (#530) Oct 8, 2021
@johnlehne johnlehne changed the title Correct the workflow name so build status image is displayed (#530) Correct workflow name so build status image is displayed (#530) Oct 8, 2021
@johnlehne johnlehne mentioned this pull request Oct 8, 2021
Closed
@nipafx
Copy link
Member

nipafx commented Oct 8, 2021

Thanks! We like to list contributions in the README - want to add yourself there?

@nipafx
Copy link
Member

nipafx commented Oct 8, 2021

Requesting @Michael1993 to finish this (or anybody else really) because I'll be out of reach very soon.

Michael1993
Michael1993 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Once we get your feedback about adding your contributions to the README.md we can get this merged.

@johnlehne
Copy link
Contributor Author

@Michael1993 I have no issues with being added to the contributions section. Is this something I should do? If so, same PR?

@Michael1993
Copy link
Member

@Michael1993 I have no issues with being added to the contributions section. Is this something I should do? If so, same PR?

Yes, please add yourself to the README.md and commit & push to this branch. That's the simplest solution.

@Michael1993
Copy link
Member

Proposed commit message:

Fix build status image (#530 / #531)

Corrected the path to the GitHub workflow build status.

Closes: #530 
PR: #531

@johnlehne
Copy link
Contributor Author

Updated commit message with what was proposed.

Added myself to contributor section as 2nd commit.

Michael1993
Michael1993 requested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@Michael1993 Michael1993 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the README - use lexicographic ordering. (Nevermind, did it myself.)

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Michael1993
Michael1993 reviewed Oct 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@johnlehne
Copy link
Contributor Author

Thank you for correcting the order of my contribution bullet point.

@Michael1993 Michael1993 merged commit 394a983 into junit-pioneer:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael1993 Michael1993 Michael1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnlehne @nipafx @Michael1993