Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New behaviour for RetryingTest for Assumptions #293

Merged
merged 6 commits into from Jul 9, 2020
Merged

New behaviour for RetryingTest for Assumptions #293

merged 6 commits into from Jul 9, 2020

Conversation

Michael1993
Copy link
Member

Closes #291.

Proposed commit message:

Skip test execution on @RetryingTest when Assumption fails (#291)

Tests that do not meet the Assumptions of those tests should be skipped.
Ensures that RetryingTest tests are skipped after the first test executes if 
an assumption is not met.

Issue: #291

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Michael1993
New test and behaviour for RetryingTest for Assumptions
2976989 
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
@Michael1993
New test and behaviour for RetryingTest for Assumptions
35c2374 
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
@Michael1993 Michael1993 requested a review from Bukama July 1, 2020 21:49
@Michael1993
Copy link
Member Author

Local build successful - please ignore that I accidentally committed twice with the same message 😢

Bukama
Bukama requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Can you please update the documentation to mentioned this behavior there?

@Bukama
Copy link
Member

Bukama commented Jul 2, 2020

Please merge the current master into the branch, to remove the Gradle issues mentioned in #290 - thank you!

@Michael1993
Merge branch 'master' into issue/291-retrying-assumptions
58040e2
@Michael1993
Update to documentation, adding cause to exception.
4332c2d 
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
@Michael1993
Spotless, why art thou spotless.
9129c21 
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
@Michael1993 Michael1993 requested a review from Bukama July 3, 2020 17:54
@Michael1993
Rewording documentation for better clarity.
75b3ff9 
Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Bukama
Bukama approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

aepfli
aepfli approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bukama Bukama merged commit 6ebf5eb into junit-pioneer:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukama Bukama Bukama approved these changes

@aepfli aepfli aepfli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RepeatFailedTest fails if assumptions are invalid
3 participants
@Michael1993 @Bukama @aepfli