Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project site links to javadoc #271

Conversation

NPException
Copy link
Contributor

This just adds project site documentation links to the java doc of extensions, as suggested in #149.

Closes #149.


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Bukama
Copy link
Member

Bukama commented Jun 4, 2020

One question: Why do you not close the <p> tags?

@NPException
Copy link
Contributor Author

One question: Why do you not close the <p> tags?

The existing sections in those javadocs do not have closing <p> tags either, so I assumed this was the desired style. Personally I'd prefer to have closing tags as well, but I didn't want to break existing conventions.

@Bukama
Copy link
Member

Bukama commented Jun 5, 2020

One question: Why do you not close the <p> tags?

The existing sections in those javadocs do not have closing <p> tags either, so I assumed this was the desired style. Personally I'd prefer to have closing tags as well, but I didn't want to break existing conventions.

From my personal point of view: Open tags are not a convention, but a bug.

@NPException
Copy link
Contributor Author

From my personal point of view: Open tags are not a convention, but a bug.

I think I agree. I added one more commit that closes all <p> tags in the Javadoc of all classes affected by this issue/PR.

@Bukama Bukama self-requested a review June 6, 2020 08:21
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm fine with it.

@Bukama Bukama requested review from Michael1993 and aepfli June 6, 2020 08:22
Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, personally I prefer all <p> and </p> tags to be on new lines, but that's probably only because that's how IntelliJ does it.

@NPException
Copy link
Contributor Author

LGTM, personally I prefer all <p> and </p> tags to be on new lines, but that's probably only because that's how IntelliJ does it.

No, that was all manually done by me. I chose to put the closing tag on the same line for existing sentences because I've seen it done like that in other places in the project. I'll happily move them on a new line if that is fine with everyone.

@Michael1993
Copy link
Member

LGTM, personally I prefer all <p> and </p> tags to be on new lines, but that's probably only because that's how IntelliJ does it.

No, that was all manually done by me. I chose to put the closing tag on the same line for existing sentences because I've seen it done like that in other places in the project. I'll happily move them on a new line if that is fine with everyone.

No need, it doesn't really add any real value. It's not worth working on it.

@Bukama Bukama added this to the Cleaner Pioneers - V1.0 milestone Jun 11, 2020
@aepfli
Copy link
Member

aepfli commented Jun 13, 2020

i am not sure if i am a fan of closing

tags. The reason is, it is not the default case. Oracle Java docs, also does not have closing tags (i see this as the default). Furthermore i understand the nature from HTML where this is coming from, but i also do think there is a difference to it than plain HTML. (and it is still valid as p tags do not have to be closed)

In HTML you structure a page, and open and closing gives you a lot of help, to figure out the structure. In Java doc, we just use it for a break and to ensure that there is a break.

Addtionally i want to discuss if an
@see <a href="http://google.com">http://google.com</a> would be also beneficiary, so it will be displayed under See also:

@NPException
Copy link
Contributor Author

NPException commented Jun 16, 2020

Oracle Java docs, also does not have closing tags (i see this as the default).

I was not aware that this is the case in the base java docs. In that case, I too would vote to leave the tags open.

Addtionally i want to discuss if an
@see <a href="http://google.com">http://google.com</a> would be also beneficiary, so it will be displayed under See also:

I have no opinion/preference on this. @Michael1993 @Bukama what is your opinion on the topic?

# Conflicts:
#	src/main/java/org/junitpioneer/jupiter/ReportEntry.java
@Bukama
Copy link
Member

Bukama commented Jun 17, 2020

Oracle Java docs, also does not have closing tags (i see this as the default).

I was not aware that this is the case in the base java docs. In that case, I too would vote to leave the tags open.

Addtionally i want to discuss if an
@see <a href="http://google.com">http://google.com</a> would be also beneficiary, so it will be displayed under See also:

I have no opinion/preference on this. @Michael1993 @Bukama what is your opinion on the topic?

We could use @see only, because the then generated see also is nothing else than for further information look at this link

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nipafx nipafx merged commit fe4339e into junit-pioneer:master Jun 20, 2020
@NPException NPException deleted the issue/149-add-project-site-links-to-javadoc branch June 20, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Javadoc link to project site?
5 participants