New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project site links to javadoc #271
Add project site links to javadoc #271
Conversation
One question: Why do you not close the |
The existing sections in those javadocs do not have closing |
From my personal point of view: Open tags are not a convention, but a bug. |
I think I agree. I added one more commit that closes all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I'm fine with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, personally I prefer all <p>
and </p>
tags to be on new lines, but that's probably only because that's how IntelliJ does it.
No, that was all manually done by me. I chose to put the closing tag on the same line for existing sentences because I've seen it done like that in other places in the project. I'll happily move them on a new line if that is fine with everyone. |
No need, it doesn't really add any real value. It's not worth working on it. |
i am not sure if i am a fan of closing tags. The reason is, it is not the default case. Oracle Java docs, also does not have closing tags (i see this as the default). Furthermore i understand the nature from HTML where this is coming from, but i also do think there is a difference to it than plain HTML. (and it is still valid as p tags do not have to be closed) In HTML you structure a page, and open and closing gives you a lot of help, to figure out the structure. In Java doc, we just use it for a break and to ensure that there is a break. Addtionally i want to discuss if an |
I was not aware that this is the case in the base java docs. In that case, I too would vote to leave the tags open.
I have no opinion/preference on this. @Michael1993 @Bukama what is your opinion on the topic? |
# Conflicts: # src/main/java/org/junitpioneer/jupiter/ReportEntry.java
We could use |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This just adds project site documentation links to the java doc of extensions, as suggested in #149.
Closes #149.
I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.