Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change automatic module name to match other names #252

Closed
wants to merge 2 commits into from
Closed

Change automatic module name to match other names #252

wants to merge 2 commits into from

Conversation

Bukama
Copy link
Member

@Bukama Bukama commented May 2, 2020

Disclaimer: Not sure if this is all what @nicolaiparlog wanted to do about it, so I marked it as a draft

fixes #251

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Bukama Bukama requested a review from nipafx May 2, 2020 09:42
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Bukama
Copy link
Member Author

Bukama commented May 2, 2020

Notes:

@nipafx
Copy link
Member

nipafx commented May 2, 2020

#251 was closed and we decided not to change anything.

@nipafx nipafx closed this May 2, 2020
@Bukama Bukama deleted the bishue251/automaticmodulename branch May 2, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipafx nipafx Awaiting requested review from nipafx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct automatic module name of pioneer
2 participants
@Bukama @nipafx