New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving gradle wrapper to default location #200
Moving gradle wrapper to default location #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is correct, but as it is the default value, there is no reason to define this, i think we are save with removing the 3 lines alltogether. The gradle wrapper task is a default gradle task, we only need to define the block when we change something
build.gradle.kts
Outdated
@@ -184,7 +184,7 @@ publishing { | |||
} | |||
|
|||
tasks.wrapper { | |||
jarFile = file(".infra/gradle/gradle-wrapper.jar") | |||
jarFile = file("gradle/wrapper/gradle-wrapper.jar") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is the default so you actually do not need to set it at all - actually we do not need the whole block, when we use default settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is the default so you actually do not need to set it at all - actually we do not need the whole block, when we use default settings
I don't know gradle very well but maybe this is needed for the option to use the gradle setting via a wrapper task. At least IntelliJ offers such an option beside use default wrapper.properties location
and use own location
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default value, and the gradle wrapper task is something, which gradle provides out of the box since verison 5 i think (do not pin me on that). but you can find that information:
Every vanilla Gradle build comes with a built-in task called wrapper. You’ll be able to find the task listed under the group "Build Setup tasks" when listing the tasks. Executing the wrapper task generates the necessary Wrapper files in the project directory. - https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:adding_wrapper
To test this, you can simply remove the block and run gradle wrapper
in your cli and see, it will work out of the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok removed the block and still seems to work. Thanks for the docs!
normally there should be also a change in the gradlew and gradlew.bat as the path has changed, and there is a different path - i am currently not sure. but we need to check those files before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regenerate gradlew and gradlew.bat with gradle wrapper
as they are pointing currently to the .infra
folder
https://github.com/Bukama/junit-pioneer/blob/issue190/movegradleconfig/gradlew#L83
https://github.com/Bukama/junit-pioneer/blob/issue190/movegradleconfig/gradlew.bat#L82
Done. Thanks again |
e0dc620
to
6094283
Compare
Title says all ;)
With this location IntelliJ could determine the correct version automaticall with both settings (using wrapper.properties and executing warpper-task) which was not the case before the change.
fixes #190
I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.