Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Checkstyle and JaCoCo to build on JDK 18 (#637)
This PR updates Checkstyle to the most recent version and removes deleted/replaced/changed properties. In addition, JaCoCo is updated. Both updates support Java 18, which fixes the currently failing build. # Deleted `allowMissingThrowsTags` and `allowUndeclaredRTE`: > properties `allowMissingThrowsTags`, `allowUndeclaredRTE` [...] should > be just removed from configs. > Behavior will change as there will be less violations in code, such > properties did not work well so their removal should be ok, as there > will be less false-positives. See: * https://checkstyle.sourceforge.io/releasenotes.html#Release_8.21 * checkstyle/checkstyle#6703 # Replaced `allowMissingJavadoc`: Replaced by [`MissingJavadocMethod`](https://checkstyle.org/config_javadoc.html#MissingJavadocMethod). That is, missing Javadoc is now allowed by default. See: * https://checkstyle.sourceforge.io/releasenotes.html#Release_8.28 * checkstyle/checkstyle#7329 # Changed `allowMissingThrowsTags`: `validateThrows` now means we can no longer omit `@throws` in Javadoc. Whenever a method declares `throws`, it must be documented. Furthermore, Checkstyle authors say: > If you need to validate `@throws` please enable property > `validateThrows` but please read documentation as there some > limitations - > https://checkstyle.org/config_javadoc.html#JavadocMethod . > Old documentation is at > https://checkstyle.sourceforge.io/version/8.27/config_javadoc.html#JavadocMethod See: * https://checkstyle.sourceforge.io/releasenotes.html#Release_8.21 * checkstyle/checkstyle#6703 --- PR: #637
- Loading branch information