Support regular expression #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julz
requested changes
Apr 1, 2021
config.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (c Config) findRule(path string) *Rule { |
There was a problem hiding this comment.
I'd make this and AliasFor use *Config too for consistency (see https://golang.org/doc/faq#methods_on_values_or_pointers)
There was a problem hiding this comment.
Thank you for review.
I fixed at 6439bcc
config.go
Outdated
| return r.Regexp.ReplaceAllString(str, r.Alias), nil | ||
| } | ||
|
|
||
| return "", fmt.Errorf("mismatch rule") |
There was a problem hiding this comment.
we can use errors.New here since there are no actual formatting instructions in the error string
|
Thanks @sachaos this is really cool! |
|
@julz Thank you! I've created PR to golangci-lint to enable to use this feature in that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes