Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var MatchedRoutePathParam = "$matchedRoutePath" changed declaration to const MatchedRoutePathParam #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeoDiKadyrov
Copy link

@LeoDiKadyrov LeoDiKadyrov commented Feb 19, 2024

I only suggested it due to following reasons:

  • John Carmack once said: "I am a full const nazi nowadays, and I chide any programmer that doesn’t const every variable and parameter that can be."
  • I'm a newbie into development, trying to learn staff and while studying source code of this library, I saw an opportunity for small change and my first PR into open source ever

All tests that are originally in master repo passed green. When I was going through the code it just confused me a bit, that a variable only used in router.go and not really mutated anywhere declared as var. Sorry if it's too small to have anyone attention and a whole PR open for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant