Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 0 as date/datetime zero value #162

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xiezhenye
Copy link
Contributor

return 0 as zero value of date/datetime to tell difference from NULL and '0000-00-00'.
e.g. insert/update a NOT NULL date column, only '0000-00-00' or 0 is valid.

@julien-duponchelle
Copy link
Owner

That sound correct.

But I worry that will force people to handle this case in their code. What is the good usage of 0000-00-00?

What others think about it?

PS: it seem some tests still failed

@baloo
Copy link
Collaborator

baloo commented Aug 5, 2016

Looks good to me, just need to make sure this is not a patch-level release. And it's shown in the changelog.

@julien-duponchelle
Copy link
Owner

@xiezhenye can you fix the tests? I will merge it after that

Thanks for the help

@xiezhenye
Copy link
Contributor Author

MySQL 5.6 tests passed. MySQL 5.7 tests seems failed to start test instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants