[SQLLINE-394] Make script engine configurable via property #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a new property
scriptEngineto specify which script engine to use (from those which are available via spi).Each script engine could have plenty of names and these names could be intersected across multiple script engines. To cope with it sqlline uses for autocompletion only those which are not referring to multiple engines and to reduce multiple names it uses only one name per engine.
a short demo of how it works https://asciinema.org/a/382251?speed=3.0
will allow to switch to a different script engine for java15+ and cope with #394