-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add bi-directional comms and run operations in tasks #135
base: main
Are you sure you want to change the base?
Conversation
Update changelog
- added _customItems - dropped 'Private' namespace - added _removeItem CommandPalette - _items changed to items - fix serialization of icon
- fix test for closing on comm_live change
- restore labIcon
SessionManager - restore refresh_running
- added app_session to capture the session in which ipylab is running.
- added open_console - wait_ready updated to wait for sessions
Added dialog to JupyterFrontEnd
Added get_open_files & get_existing_directory
…o supported. Added python side plugin support using pluggy (new dependency). Current hooks: on_frontend_error, get_ipylab_backend_class & register_launcher register_launcher is not implemented yet.
… yet provide built in type hints.
- launcher - kerenel status watcher and onKernelLost to dispose instead of using 'comm_live_update'. - execute_command on AsyncWidgetBase instead of execute on CommandRegistry. Renamed - JupyterFrontEnd.commands to JupyterFrontEnd.command Removed - Hookspec: get_ipylab_backend_class & run_once_at_startup
added overload of save_changes to only save when com_live is true JupyterFrontEndModel added close overload
…other kernel via the model in that kernel. renamed `execute_method` to `executeMethod` schedule_operation renamed to scheduleOperation
Regarding creating a new session without a notebook. I'm wondering if the new session should be based around a document... Currently, the function It'd be better to use
|
…ypens are not allowed).
Type hint and type checking fixes. Minimum Python v3.11.
Pre-commit fixes (linting)
…Jupyterlab shared packages.
Thanks @fleming79 for working on this! And sorry for the delay, I'll try to have a look soon. |
@jtpio - no problem. I've been learning as I go and using it for my own purposes. As an aside, I was looking at your PR for Ipywidgets jupyter-widgets/ipywidgets#3004 from 2020 (which is still open) and saw a bit of a discussion having a widgetManager on a per-kernel basis.
I think this concept is worth pursuing and am currently investigating how difficult it may be to implement. It would solve the issue in this PR associated with needing to create a WidgetManager and manually register widgetmodels, and the problem of widget comms shutting down when the notebook is closed. |
I noticed that jupyter-widgets/ipywidgets#3004 has now been merged - that's great! |
// For the moment we'll use a dummy session.
// In future it might be better to support a document...
const session = sessionContext.session;
const context = {};
(context as any)['sessionContext'] = sessionContext;
(context as any)['saveState'] = new Signal({});
(context as any).saveState.connect(() => {
null;
});
registerWidgetManager(context as any, rendermime, [] as any); |
This adds supports for asynchronous bi-directional messaging from the Python objects running in the Python kernel with the JavaScript Frontend. If this is adopted, it would be a major release.
app
as a property of Panel.