[Fix] require-default-props: fix config schema
#3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3605 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 132 132
Lines 9295 9295
Branches 3397 3397
=======================================
Hits 9074 9074
Misses 221 221
|
ljharb
changed the title
require-default-props: fix config schema
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3604
Removes extraneous “allow” keyword from JSON schema definition. I couldn’t find any references to this keyword in JSON schema, nor documentation on its purpose, but it seems to break the TypeScript definitions generated in projects like eslint-define-config.
If the “allow” keyword has a purpose here that I’m not aware of, please feel free to close this PR.