Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488

Merged
merged 1 commit into from Nov 21, 2022
Merged

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -16,9 +16,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
* [`sort-prop-types`]: restore autofixing ([#3452][] @ROSSROSALES)
* [`no-unknown-property`]: do not check `fbs` elements ([#3494][] @brianogilvie)
* [`jsx-newline`]: No newline between comments and jsx elements ([#3493][] @justmejulian)
* [`jsx-no-leaked-render`]: Don't report errors on empty strings if React >= v18 ([#3488][] @himanshu007-creator)

[#3494]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3494
[#3493]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3493
[#3488]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3488
[#3461]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3461
[#3452]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3452
[#3449]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3449
Expand Down
4 changes: 4 additions & 0 deletions lib/rules/jsx-no-leaked-render.js
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@

const docsUrl = require('../util/docsUrl');
const report = require('../util/report');
const testReactVersion = require('../util/version').testReactVersion;
const isParenthesized = require('../util/ast').isParenthesized;

//------------------------------------------------------------------------------
Expand Down Expand Up @@ -130,6 +131,9 @@ module.exports = {
}
}

if (testReactVersion(context, '>= 18') && leftSide.type === 'Literal' && leftSide.value === '') {
return;
}
report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', {
node,
fix(fixer) {
Expand Down
82 changes: 61 additions & 21 deletions tests/lib/rules/jsx-no-leaked-render.js
View file
Open in desktop
Expand Up @@ -199,45 +199,85 @@ ruleTester.run('jsx-no-leaked-render', rule, {
// Common invalid cases with default options
{
code: `
const Example = () => {
return (
<>
{0 && <Something/>}
{'' && <Something/>}
{NaN && <Something/>}
</>
)
}
const Example = () => {
return (
<>
{0 && <Something/>}
{'' && <Something/>}
{NaN && <Something/>}
</>
)
}
`,
features: ['fragment'],
errors: [
{
message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
line: 5,
column: 14,
column: 16,
},
{
message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
line: 6,
column: 14,
column: 16,
},
{
message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
line: 7,
column: 16,
},
],
output: `
const Example = () => {
return (
<>
{0 ? <Something/> : null}
{'' ? <Something/> : null}
{NaN ? <Something/> : null}
</>
)
}
`,
himanshu007-creator marked this conversation as resolved.
Show resolved Hide resolved
settings: { react: { version: '17.999.999' } },
},

{
code: `
const Example = () => {
return (
<>
{0 && <Something/>}
{'' && <Something/>}
{NaN && <Something/>}
</>
)
}
`,
features: ['fragment'],
errors: [
{
message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
line: 5,
column: 16,
},
{
message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
line: 7,
column: 14,
column: 16,
},
],
output: `
const Example = () => {
return (
<>
{0 ? <Something/> : null}
{'' ? <Something/> : null}
ljharb marked this conversation as resolved.
Show resolved Hide resolved
{NaN ? <Something/> : null}
</>
)
}
const Example = () => {
return (
<>
{0 ? <Something/> : null}
{'' && <Something/>}
{NaN ? <Something/> : null}
</>
)
}
`,
settings: { react: { version: '18.0.0' } },
},

// Invalid tests with both strategies enabled (default)
Expand Down