Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3485

Closed
wants to merge 1 commit into from
Closed

Update README.md #3485

wants to merge 1 commit into from

Conversation

vixero-dev
Copy link

The existing code from the docs will result in Cannot find module 'eslint-plugin-react/configs/recommended'. Updated the README page with a working example.

The existing code from the docs will result in `Cannot find module 'eslint-plugin-react/configs/recommended'`.  Updated the README page with a working example.
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #3485 (93dbceb) into master (865ed16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3485   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         129      129           
  Lines        9192     9192           
  Branches     3331     3331           
=======================================
  Hits         8969     8969           
  Misses        223      223           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vixero-dev vixero-dev closed this Nov 14, 2022
@vixero-dev vixero-dev reopened this Nov 14, 2022
@vixero-dev vixero-dev closed this Nov 14, 2022
@vixero-dev vixero-dev reopened this Nov 14, 2022
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you just removing parts of the readme that were added in #3429?

@ljharb
Copy link
Member

ljharb commented Nov 14, 2022

Please note, just like everywhere on github, you should be reading docs for the tagged version you're using, not just what's on main/master. For npm packages, read the published readme, not the repo's readme.

@ljharb ljharb marked this pull request as draft November 14, 2022 14:07
@vixero-dev
Copy link
Author

vixero-dev commented Nov 14, 2022

Why are you just removing parts of the readme that were added in #3429?

I am proposing this change because according to eslint docs, shareable configs are configured in a different way than provided in the current readme.

Please note, just like everywhere on github, you should be reading docs for the tagged version you're using, not just what's on main/master.

Would you please give a more detailed explanation, or suggest some documents? My assumption is that the master is the latest stable version. Why is my assumption incorrect?

For npm packages, read the published readme, not the repo's readme.

Thank you for pointing that out. I assumed those readme's were the same.

@ljharb
Copy link
Member

ljharb commented Nov 15, 2022

That assumption is incorrect - on almost every repo on github - whenever there are unpublished changes, as there are here.

@ljharb ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare November 18, 2022 17:19
@ljharb
Copy link
Member

ljharb commented Nov 29, 2022

This seems fine to close, since the readme on master is correct. Happy to reopen after the next release if there's still something that needs changing.

@ljharb ljharb closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants