[Fix] jsx-indent-props: Reset line.isUsingOperator correctly after ternary (#3146)

[tobiaswaltl]

Closes #3146

When having a JSX element after a ternary and there are not only spaces before the opening bracket (e.g. due to a return keyword) line.isUsingOperator is not reset correctly and the rule enforces a higher indent.

Example:

export const LintExample2 = () => {
  const foo = true
    ? <div id="id">test</div>
    : false;

  return <div
    id="id" // linter complains: ESLint: Expected indentation of 6 space characters but found 4.(react/jsx-indent-props)
  >
    test
  </div>;
};

[ljharb]

Just looking at the test cases, this doesn't seem right.

[ljharb]

Can we add some test cases that use tabs, since that's what's being removed here?

[tobiaswaltl]

Yes, I've added them.

[codecov-commenter]

Codecov Report

Merging #3157 (3db5285) into master (d56fdb8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3157   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         119      119           
  Lines        8130     8130           
  Branches     2895     2895           
=======================================
  Hits         7928     7928           
  Misses        202      202           

Impacted Files	Coverage Δ
lib/rules/jsx-indent-props.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56fdb8...3db5285. Read the comment docs.