Resurrection of #2713: add componentWrapperFunctions setting #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2268. Co-authored-by: Johnny Zabala <jzabala.s@gmail.com> Co-authored-by: Landon Schropp <schroppl@gmail.com>
|
@ljharb Bump. |
|
@ljharb Bump again... |
|
@LandonSchropp for future reference, please do not create a redundant PR - instead, comment a link to your branch/commits on the original PR, and i'll update it with those. Now I have to keep both PRs open and in sync until both land, otherwise there'll be an orphan PR ref for eternity. I'll take a look today. |
|
@LandonSchropp i'm unable to force push to your fork, despite the "allow edits" checkbox being checked - looks like this is because you forked not from this repo, but from jzabala's fork. I'll force push to #2713, and if you can force push the same exact sha to this PR's branch, then i can land both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt to resurrect the #2713 PR by @jzabala. I haven't changed anything in the original PR other than making the changes suggested by @ljharb and rebasing on top of the latest master.
Please let me know if there's anything else required. I'd really love to land this PR so I can use it. Thanks!
CC @jzabala, @flut1, @ljharb, @jillesme