Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-script: fix <a href ... /> (no value) #2764

Closed
wants to merge 1 commit into from
Closed

jsx-no-script: fix <a href ... /> (no value) #2764

wants to merge 1 commit into from

Conversation

wmertens
Copy link

No description provided.

ljharb
ljharb requested changes Aug 23, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - please provide a regression test?

(note that <a href /> does in fact have a value of true, so let's also add <a href={true} /> and false etc as test cases)

@ljharb ljharb marked this pull request as draft October 15, 2020 17:52
@ljharb
Copy link
Member

ljharb commented Sep 20, 2021

This appears to have been fixed in 63d5a1b, to fix #2871.

@ljharb ljharb closed this Sep 20, 2021
@wmertens wmertens deleted the patch-2 branch September 21, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmertens @ljharb