Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] prop-types: avoid crash when spreading any type #2606

Merged
merged 1 commit into from Mar 26, 2020
Merged

[Fix] prop-types: avoid crash when spreading any type #2606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/util/ast.js
View file
Open in desktop
Expand Up @@ -155,7 +155,7 @@ function stripQuotes(string) {
* Retrieve the name of a key node
* @param {Context} context The AST node with the key.
* @param {ASTNode} node The AST node with the key.
* @return {string} the name of the key
* @return {string | undefined} the name of the key
*/
function getKeyValue(context, node) {
if (node.type === 'ObjectTypeProperty') {
Expand All @@ -172,6 +172,9 @@ function getKeyValue(context, node) {
return;
}
const key = node.key || node.argument;
if (!key) {
return;
}
return key.type === 'Identifier' ? key.name : key.value;
}

Expand Down
11 changes: 11 additions & 0 deletions tests/lib/rules/prop-types.js
View file
Open in desktop
Expand Up @@ -1650,6 +1650,17 @@ ruleTester.run('prop-types', rule, {
'}'
].join('\n'),
parser: parsers.BABEL_ESLINT
}, {
code: `
type FooProps = {
...any,
...42,
}
function Foo(props: FooProps) {
return <p />;
}
`,
parser: parsers.BABEL_ESLINT
}, {
code: [
'type Person = {',
Expand Down