Guard against 0 length specifiers for proptypes #2435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My co-worker was entered `import {} from "prop-types` in preparation to declare the prop types for his component.
Upon doing this, eslint crashed as it could not find `local` on undefined.
|
@dmkato thanks! could you try to add a test that covers this? |
ljharb
reviewed
Dec 13, 2019
| propTypesPackageName = node.specifiers[0].local.name; | ||
| if (node.specifiers.length > 0) { | ||
| propTypesPackageName = node.specifiers[0].local.name; | ||
| } |
|
I've converted this to a draft pending @dmkato's response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My co-worker was entered
import {} from "prop-typesin preparation to declare the prop types for his component.Upon doing this, eslint crashed as it could not find
localon undefined.