Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle react version detect errors #2336

Merged
merged 2 commits into from Jun 28, 2019
Merged

Handle react version detect errors #2336

merged 2 commits into from Jun 28, 2019

Commits on Jun 28, 2019

  1. version detection: Add tests 

    - Warn only once for failure to detect react version

Ref: jsx-eslint#2276
    @abhishekdev
    abhishekdev committed Jun 28, 2019
    Copy the full SHA
    f59e927 View commit details
    Browse the repository at this point in the history

  2. version detection: Do not throw a raw error after the first warning 

    - Adjust the conditions to always assume a latest react version when e.code === 'MODULE_NOT_FOUND'
- The `warnedForMissingVersion` flag only controls the warning message and not the handling of the error

Ref: jsx-eslint#2276
    @abhishekdev
    abhishekdev committed Jun 28, 2019
    Copy the full SHA
    8fbf50c View commit details
    Browse the repository at this point in the history