Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop crashing on undefined or null properties in flow intersection #1860

Merged
merged 3 commits into from
Jul 4, 2018

Conversation

nicholas-l
Copy link
Contributor

Similar to other fix for flow intersection (#1806). I am not sure if this is the correct fix but the change stops Eslint crashing.

Fixes #1770
Fixes #1631

Similar to other fix for flow intersection (jsx-eslint#1806)
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good; can we add a regression test tho?

@nicholas-l
Copy link
Contributor Author

I have added the cases from the two issues

@ljharb ljharb merged commit 4e26092 into jsx-eslint:master Jul 4, 2018
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Union error with Flow types prop-types failing to parse flow type annotations
2 participants