Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation check for React.DOM factories #1530

Merged
merged 1 commit into from Nov 11, 2017
Merged

Deprecation check for React.DOM factories #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/rules/no-deprecated.md
View file
Open in desktop
Expand Up @@ -23,6 +23,9 @@ const propTypes = {
foo: PropTypes.bar,
};

//Any factories under React.DOM
React.DOM.div();

import React, { PropTypes } from 'react';
```

Expand Down
3 changes: 2 additions & 1 deletion lib/rules/no-deprecated.js
View file
Open in desktop
Expand Up @@ -68,7 +68,8 @@ module.exports = {
// 15.5.0
deprecated[`${pragma}.createClass`] = ['15.5.0', 'the npm module create-react-class'];
deprecated[`${pragma}.PropTypes`] = ['15.5.0', 'the npm module prop-types'];

// 15.6.0
deprecated[`${pragma}.DOM`] = ['15.6.0', 'the npm module react-dom-factories'];
return deprecated;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/lib/rules/no-deprecated.js
View file
Open in desktop
Expand Up @@ -174,5 +174,11 @@ ruleTester.run('no-deprecated', rule, {
errors: [{
message: 'ReactPerf.printDOM is deprecated since React 15.0.0, use ReactPerf.printOperations instead'
}]
},
{
code: 'React.DOM.div',
errors: [{
message: 'React.DOM is deprecated since React 15.6.0, use the npm module react-dom-factories instead'
}]
}]
});