false positive in no-unused-prop-types
#1105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test case to show a false positive of the rule
no-unused-prop-types
.It happens when using both
nextProps
andthis.props
in a lifecycle method.The
prop-types
rule does complain (as it should) when not specifying a propType forfoo
.I tried to dive into the code and find the difference (and understand why those 2 rules aren't based on the same "parser") but I got lost.