Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test false positive component detection for destructured createElement #1098

Merged
merged 1 commit into from Dec 27, 2018
+42 −0
Merged

Test false positive component detection for destructured createElement #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 42 additions & 0 deletions tests/lib/rules/display-name.js
View file
Open in desktop
Expand Up @@ -362,6 +362,48 @@ ruleTester.run('display-name', rule, {
module.exports = someDecorator;
`,
parser: 'babel-eslint'
}, {
code: [
'import React, {createElement} from "react";',
'const SomeComponent = (props) => {',
' const {foo, bar} = props;',
' return someComponentFactory({',
' onClick: () => foo(bar("x"))',
' });',
'};'
].join('\n')
}, {
code: [
'import React, {createElement} from "react";',
'const SomeComponent = (props) => {',
' const {foo, bar} = props;',
' return someComponentFactory({',
' onClick: () => foo(bar("x"))',
' });',
'};'
].join('\n'),
parser: 'babel-eslint'
}, {
code: [
'import React, {Component} from "react";',
'function someDecorator(ComposedComponent) {',
' return class MyDecorator extends Component {',
' render() {return <ComposedComponent {...this.props} />;}',
' };',
'}',
'module.exports = someDecorator;'
].join('\n')
}, {
code: [
'import React, {Component} from "react";',
'function someDecorator(ComposedComponent) {',
' return class MyDecorator extends Component {',
' render() {return <ComposedComponent {...this.props} />;}',
' };',
'}',
'module.exports = someDecorator;'
].join('\n'),
parser: 'babel-eslint'
}, {
code: `
const element = (
Expand Down