Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test require-default-props rule filter of undefined exception #1045

Merged
merged 1 commit into from Jan 29, 2017
Merged

Test require-default-props rule filter of undefined exception #1045

merged 1 commit into from Jan 29, 2017

Conversation

CarlRosell
Copy link
Contributor

Fix error while trying to map over annotation.properties that are undefined for AnyTypeAnnotation

Fix #1043.

ljharb
ljharb approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb added the bug label Jan 25, 2017
lencioni
lencioni approved these changes Jan 29, 2017
View reviewed changes
Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like this needs a rebase and some conflict resolution FYI

@CarlRosell
Copy link
Contributor Author

After merging with master the only thing left was the test 👍 #1018 solved this one as well.

@lencioni
Copy link
Collaborator

Thanks @CarlRosell! Will you please squash these down to a single commit?

@CarlRosell CarlRosell mentioned this pull request Jan 29, 2017
Closed
@CarlRosell
Copy link
Contributor Author

After some struggle squashing a merge with master, I think I managed to get things right at the end 😉

@ljharb ljharb merged commit 30e0206 into jsx-eslint:master Jan 29, 2017
@ljharb ljharb changed the title Fix require-default-props rule filter of undefined exception Test require-default-props rule filter of undefined exception Jan 29, 2017
@CarlRosell CarlRosell deleted the fix-require-default-props branch January 29, 2017 22:03
@renovate-bot renovate-bot mentioned this pull request Feb 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lencioni lencioni lencioni approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CarlRosell @lencioni @ljharb