Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 8.x #3055

Closed
Tracked by #25
MichaelDeBoey opened this issue Aug 29, 2021 · 14 comments 路 Fixed by #3059
Closed
Tracked by #25

Support ESLint 8.x #3055

MichaelDeBoey opened this issue Aug 29, 2021 · 14 comments 路 Fixed by #3059

Comments

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Aug 29, 2021

ESLint v8.0.0 is released 馃帀

It would be awesome to have official ESLint 8 support. 馃憡
I'm happy to help where I can of course 馃檪

@ljharb
Copy link
Member

ljharb commented Aug 29, 2021

Support will wait until an actual release (betas don鈥檛 count).

@UziTech
Copy link

UziTech commented Oct 13, 2021

Actual release has happened.

@duasfh
Copy link

duasfh commented Oct 15, 2021

If someone having troubles installing this, having eslint 8>, (and similar libraries, like plugin:react-hooks),
use --force flag (on own risk).
I hope it more-less safe, as it should not contain critical incompatible differences between eslint 7.9/8.0.1 version for running this lib.

@ljharb
Copy link
Member

ljharb commented Oct 15, 2021

It is very much unsafe to use the force flag, or to ignore peer dep warnings. The only safe choice is to remain on eslint 7 until all the eslint things you use support it officially.

@gajus
Copy link

gajus commented Oct 25, 2021

What's the reason this is being delayed?

@ljharb
Copy link
Member

ljharb commented Oct 25, 2021

@gajus it's not "being delayed", it's "more work than anyone's been able to untangle yet". See the PR (#3059) for the current set of blockers.

@ljharb
Copy link
Member

ljharb commented Oct 25, 2021

To be clear, an eslint major always, without exception, takes weeks to months before the rest of the eslint ecosystem is able to fully catch up. There's no way to accelerate or avoid this short of people pitching in their time to fix the issues, or, short of the eslint team deciding to avoid breaking changes.

The cost of participating in the ecosystem - and benefiting from shared plugins and configs - is that you can't be on the bleeding edge of "core" anymore. This is just as true with webpack, babel, typescript, react, etc.

@gajus
Copy link

gajus commented Oct 25, 2021

@gajus it's not "being delayed", it's "more work than anyone's been able to untangle yet". See the PR (#3059) for the current set of blockers.

Sorry 鈥撀爄t was not clear from just looking at this PR that there are outstanding blockers. That's all I was asking. Thank you for the context. (Just realized that this isn't even a PR. Discovered this issue through another thread.)

@skedwards88
Copy link

Until this is resolved, it would be helpful to update the installation instructions on https://www.npmjs.com/package/eslint-plugin-react. (Right now, they do not mention that eslint version 8 is not supported, so if you follow the installation instructions as given, you get an error.)

@ljharb
Copy link
Member

ljharb commented Nov 3, 2021

@skedwards88 sure, done in bf08998, but it won't likely be published until we support eslint 8 anyways.

@silkfire
Copy link

@ljharb Will you push a release soon?

@ximex
Copy link

ximex commented Nov 10, 2021

@silkfire i would say they will: 21e01b6

@ximex
Copy link

ximex commented Nov 10, 2021

on npm already released: https://www.npmjs.com/package/eslint-plugin-react/v/7.27.0

@gajus
Copy link

gajus commented Nov 10, 2021

Thank you everyone 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

8 participants