[Breaking] drop node < 4 support #1038
Merged
+433
−434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, require template literals instead of concatenation, and auto fix.
|
Wow! Great! Thanks for all this work. I'll try to review this PR tomorrow. |
ljharb
force-pushed
the
drop_pre_node_4
branch
from
180d96e to
a4ab961
Compare
lencioni
approved these changes
Jan 29, 2017
|
master must absolutely be published with v6, to fix the incorrect breaking changes in it, before this is merged and v7 is ready. |
ljharb
force-pushed
the
drop_pre_node_4
branch
from
a4ab961 to
2eed7fb
Compare
ljharb
force-pushed
the
drop_pre_node_4
branch
2 times, most recently
from
cb721e8 to
87026a1
Compare
ljharb
force-pushed
the
drop_pre_node_4
branch
3 times, most recently
from
1e272a4 to
bc91108
Compare
Merged
|
@yannickcr please don't release v7 before merging all the v7-tagged PRs; I'll update this one shortly and merge it today. |
|
Ho, I was more in the idea the release the v7 to be React 15.5.0 compatible and to postpone theses breaking changes for the v8. But I'm ok to do all of this in a single major release. |
1 task
This was referenced Sep 12, 2024
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some commits recently which fix support down to node 0.10 - those must be published in the 6.x line prior to merging this.
Merging this will be a semver-major change - it drops < node 4 support, and drops support for eslint v2. In the process, we'll be able to use any syntax and API that node 4 supports, yay!
I also enabled rules requiring template literals instead of concatenation, and autofixed them, both because I think it's a superior approach, and because it illustrates some of the new syntax we'll get to use :-)
(I'll manually keep this rebased and updated as time goes by, so ideally it will always be ready to merge when v7 comes along)