Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eslint-plugin-flow-vars. #2842

Merged
merged 2 commits into from Feb 9, 2017
Merged

Remove eslint-plugin-flow-vars. #2842

merged 2 commits into from Feb 9, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Summary
Drops eslint-plugin-flow-vars. It doesn't seem to be used, or be a peerDependency. Also, installing it gives the following warning.

warning eslint-plugin-flow-vars@0.5.0: eslint-plugin-flow-vars has been deprecated in favor of eslint-plugin-flowtype@2.4.0 or higher

Test plan
Nothing should change.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

wtgtybhertgeghgtwtg commented Feb 9, 2017

The yarn.lock grows, but that's because eslint-plugin-react did a few things to fix support for eslint@2.0.0, and the polyfill they used has a weird dependency tree. Luckily, a new major version is on it's way, so that can be fixed soon.

@cpojer cpojer merged commit 5695029 into jestjs:master Feb 9, 2017
@cpojer
Copy link
Member

cpojer commented Feb 9, 2017

thanks!

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the drop-eslint-plugin-flow-vars branch February 9, 2017 23:30
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
* Remove `eslint-plugin-flow-vars`.

* Put `testMatch` back on a single line.  How did that even happen?
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Remove `eslint-plugin-flow-vars`.

* Put `testMatch` back on a single line.  How did that even happen?
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants