Merge pull request #1276 from Hypnosphi/fix/no-find-dom-node

Make no-find-dom-node work correctly with named imports
jsx-eslint · Jun 26, 2017 · f70b417 · f70b417
2 parents e670022 + cbe8ae9
commit f70b417
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/rules/no-find-dom-node.js b/lib/rules/no-find-dom-node.js
@@ -29,7 +29,7 @@ module.exports = {
         var callee = node.callee;
 
         var isfindDOMNode =
-          (callee.object && callee.object.callee && callee.object.callee.name === 'findDOMNode') ||
+          (callee.name === 'findDOMNode') ||
           (callee.property && callee.property.name === 'findDOMNode')
         ;
 

diff --git a/tests/lib/rules/no-find-dom-node.js b/tests/lib/rules/no-find-dom-node.js
@@ -106,5 +106,19 @@ ruleTester.run('no-find-dom-node', rule, {
     errors: [{
       message: 'Do not use findDOMNode'
     }]
+  }, {
+    code: [
+      'class Hello extends Component {',
+      '  componentDidMount() {',
+      '    this.node = findDOMNode(this);',
+      '  }',
+      '  render() {',
+      '    return <div>Hello</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    errors: [{
+      message: 'Do not use findDOMNode'
+    }]
   }]
 });