[Fix] jsx-handler-names: Skip inline handlers when checkInlineFunct…

…ion=false Fixes #2832
jsx-eslint · Oct 16, 2020 · efd3da3 · efd3da3
1 parent aeff5ea
commit efd3da3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,9 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 
 ### Fixed
 * [`jsx-indent-props`]: Apply indentation when using brackets ([#2826][] @Moong0122)
+* [`jsx-handler-names`]: Skip inline handlers when checkInlineFunction=false ([#2833][] @onigoetz)
 
+[#2833]: https://github.com/yannickcr/eslint-plugin-react/issues/2833
 [#2826]: https://github.com/yannickcr/eslint-plugin-react/issues/2826
 
 ## [7.21.4] - 2020.10.09

diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -106,6 +106,7 @@ module.exports = {
         if (
           !node.value
           || !node.value.expression
+          || (!checkInlineFunction && isInlineHandler(node))
           || (
             !checkLocal
             && (isInlineHandler(node)

diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js
@@ -59,6 +59,11 @@ ruleTester.run('jsx-handler-names', rule, {
     options: [{
       checkLocalVariables: false
     }]
+  }, {
+    code: '<TestComponent onChange={event => window.alert(event.target.value)} />',
+    options: [{
+      checkInlineFunction: false
+    }]
   }, {
     code: '<TestComponent onChange={() => handleChange()} />',
     options: [{