[Fix] jsx-no-target-blank: avoid a crash with a non-string literal

Fixes #2851.
jsx-eslint · Nov 6, 2020 · edbbd79 · edbbd79
1 parent 5f6350a
commit edbbd79
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,9 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 ### Fixed
 * [`display-name`]/component detection: avoid a crash on anonymous components ([#2840][] @ljharb)
 * [`prop-types`]: function in class that returns a component causes false warning in typescript ([#2843][] @SyMind)
+* [`jsx-no-target-blank`]: avoid a crash with a non-string literal ([#2851][] @ljharb)
 
+[#2851]: https://github.com/yannickcr/eslint-plugin-react/issues/2851
 [#2843]: https://github.com/yannickcr/eslint-plugin-react/pull/2843
 [#2840]: https://github.com/yannickcr/eslint-plugin-react/issues/2840
 [#2835]: https://github.com/yannickcr/eslint-plugin-react/pull/2835

diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -23,7 +23,7 @@ function isTargetBlank(attr) {
       attr.value.type === 'JSXExpressionContainer'
       && attr.value.expression
       && attr.value.expression.value
-      && attr.value.expression.value.toLowerCase() === '_blank'
+      && String(attr.value.expression.value).toLowerCase() === '_blank'
     ));
 }
 

diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js
@@ -89,6 +89,9 @@ ruleTester.run('jsx-no-target-blank', rule, {
     {
       code: '<a href="foobar" target="_blank" rel="noopener"></a>',
       options: [{allowReferrer: true}]
+    },
+    {
+      code: '<a target={3} />'
     }
   ],
   invalid: [{