[Fix] no-unused-state: handle optional chaining

Fixes #2515
jsx-eslint · Mar 8, 2020 · da7a045 · da7a045
1 parent 9861469
commit da7a045
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 15 deletions.
diff --git a/lib/rules/no-unused-state.js b/lib/rules/no-unused-state.js
@@ -415,7 +415,7 @@ module.exports = {
         handleAssignment(node.id, node.init);
       },
 
-      MemberExpression(node) {
+      'MemberExpression, OptionalMemberExpression'(node) {
         if (!classInfo) {
           return;
         }

diff --git a/tests/helpers/parsers.js b/tests/helpers/parsers.js
@@ -1,11 +1,19 @@
 'use strict';
 
 const path = require('path');
+const semver = require('semver');
+const version = require('eslint/package.json').version;
 
 const NODE_MODULES = '../../node_modules';
 
 module.exports = {
   BABEL_ESLINT: path.join(__dirname, NODE_MODULES, 'babel-eslint'),
   TYPESCRIPT_ESLINT: path.join(__dirname, NODE_MODULES, 'typescript-eslint-parser'),
-  '@TYPESCRIPT_ESLINT': path.join(__dirname, NODE_MODULES, '@typescript-eslint/parser')
+  '@TYPESCRIPT_ESLINT': path.join(__dirname, NODE_MODULES, '@typescript-eslint/parser'),
+  TS: function TS(tests) {
+    if (semver.satisfies(version, '>= 5')) {
+      return tests;
+    }
+    return [];
+  }
 };
diff --git a/tests/lib/rules/jsx-no-comment-textnodes.js b/tests/lib/rules/jsx-no-comment-textnodes.js
@@ -9,20 +9,11 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
-const semver = require('semver');
-const version = require('eslint/package.json').version;
 const RuleTester = require('eslint').RuleTester;
 const rule = require('../../../lib/rules/jsx-no-comment-textnodes');
 
 const parsers = require('../../helpers/parsers');
 
-function TS(tests) {
-  if (semver.satisfies(version, '>= 5')) {
-    return tests;
-  }
-  return [];
-}
-
 const parserOptions = {
   ecmaVersion: 2018,
   sourceType: 'module',
@@ -182,7 +173,7 @@ ruleTester.run('jsx-no-comment-textnodes', rule, {
       code: '<pre>&#x2F;&#42; TODO: Write perfect code &#42;&#x2F;</pre>',
       parser: parsers.BABEL_ESLINT
     }
-  ].concat(TS([
+  ].concat(parsers.TS([
     {
       code: `
       class Comp1 extends Component {
@@ -388,7 +379,7 @@ ruleTester.run('jsx-no-comment-textnodes', rule, {
       parser: parsers.BABEL_ESLINT,
       errors: [{message: 'Comments inside children section of tag should be placed inside braces'}]
     }
-  ].concat(TS([
+  ].concat(parsers.TS([
     {
       code: `
       class Comp1 extends Component {

diff --git a/tests/lib/rules/no-unused-state.js b/tests/lib/rules/no-unused-state.js
@@ -25,7 +25,7 @@ function getErrorMessages(unusedFields) {
 }
 
 eslintTester.run('no-unused-state', rule, {
-  valid: [
+  valid: [].concat(
     `function StatelessFnUnaffectedTest(props) {
        return <SomeComponent foo={props.foo} />;
     };`,
@@ -231,6 +231,28 @@ eslintTester.run('no-unused-state', rule, {
           }
         }`,
       parser: parsers.BABEL_ESLINT
+    }, parsers.TS([{
+      code: `
+        class OptionalChaining extends React.Component {
+          constructor() {
+            this.state = { foo: 0 };
+          }
+          render() {
+            return <SomeComponent foo={this.state?.foo} />;
+          }
+        }`,
+      parser: parsers['@TYPESCRIPT_ESLINT']
+    }]), {
+      code: `
+        class OptionalChaining extends React.Component {
+          constructor() {
+            this.state = { foo: 0 };
+          }
+          render() {
+            return <SomeComponent foo={this.state?.foo} />;
+          }
+        }`,
+      parser: parsers.BABEL_ESLINT
     },
     `class VariableDeclarationTest extends React.Component {
         constructor() {
@@ -795,7 +817,7 @@ eslintTester.run('no-unused-state', rule, {
       `,
       parser: parsers.TYPESCRIPT_ESLINT
     }
-  ],
+  ),
 
   invalid: [
     {