[Fix] no-render-return-value: should warn when used in assignment e…

…xpression Fixes #2461.
jsx-eslint · Oct 11, 2019 · da2c7d2 · da2c7d2
1 parent 360d74a
commit da2c7d2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/no-render-return-value.js b/lib/rules/no-render-return-value.js
@@ -58,7 +58,8 @@ module.exports = {
           parent.type === 'VariableDeclarator' ||
           parent.type === 'Property' ||
           parent.type === 'ReturnStatement' ||
-          parent.type === 'ArrowFunctionExpression'
+          parent.type === 'ArrowFunctionExpression' ||
+          parent.type === 'AssignmentExpression'
         ) {
           context.report({
             node: callee,

diff --git a/tests/lib/rules/no-render-return-value.js b/tests/lib/rules/no-render-return-value.js
@@ -96,6 +96,16 @@ ruleTester.run('no-render-return-value', rule, {
     errors: [{
       message: 'Do not depend on the return value from ReactDOM.render'
     }]
+  }, {
+    code: 'this.o = ReactDOM.render(<div />, document.body);',
+    errors: [{
+      message: 'Do not depend on the return value from ReactDOM.render'
+    }]
+  }, {
+    code: 'var v; v = ReactDOM.render(<div />, document.body);',
+    errors: [{
+      message: 'Do not depend on the return value from ReactDOM.render'
+    }]
   }, {
     code: 'var inst = React.render(<div />, document.body);',
     settings: {