[Fix] no-arrow-function-lifecycle: prevent crashing on ClassProperty

Fixes #3093
jsx-eslint · Oct 5, 2021 · c70163d · c70163d
1 parent f93f90a
commit c70163d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/no-arrow-function-lifecycle.js b/lib/rules/no-arrow-function-lifecycle.js
@@ -44,6 +44,10 @@ module.exports = {
      */
     function reportNoArrowFunctionLifecycle(properties) {
       properties.forEach((node) => {
+        if (!node || !node.value) {
+          return;
+        }
+
         const propertyName = astUtil.getPropertyName(node);
         const nodeType = node.value.type;
         const isLifecycleMethod = (

diff --git a/tests/lib/rules/no-arrow-function-lifecycle.js b/tests/lib/rules/no-arrow-function-lifecycle.js
@@ -348,7 +348,18 @@ ruleTester.run('no-arrow-function-lifecycle', rule, {
         });
       `,
     },
-  ],
+  ].concat(
+    parsers.TS([
+      {
+        code: `
+          class MyComponent extends React.Component {
+            onChange: () => void;
+          }
+        `,
+        parser: parsers['@TYPESCRIPT_ESLINT'],
+      },
+    ])
+  ),
 
   invalid: [
     {