fix(jsx-sort-props): remove the use of localeCompare

jsx-eslint · Jan 28, 2020 · bbb31b9 · bbb31b9
1 parent e69b113
commit bbb31b9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/rules/jsx-sort-props.js b/lib/rules/jsx-sort-props.js
@@ -72,7 +72,7 @@ function contextCompare(a, b, options) {
     aProp = aProp.toLowerCase();
     bProp = bProp.toLowerCase();
   }
-  return aProp.localeCompare(bProp);
+  return aProp < bProp ? -1 : 1;
 }
 
 /**
@@ -84,7 +84,7 @@ function contextCompare(a, b, options) {
 function getGroupsOfSortableAttributes(attributes) {
   const sortableAttributeGroups = [];
   let groupCount = 0;
-  for (let i = 0; i < attributes.length; i++) {
+  for (let i = 0; i < attributes.length; i += 1) {
     const lastAttr = attributes[i - 1];
     // If we have no groups or if the last attribute was JSXSpreadAttribute
     // then we start a new group. Append attributes to the group until we
@@ -94,7 +94,7 @@ function getGroupsOfSortableAttributes(attributes) {
       (lastAttr.type === 'JSXSpreadAttribute' &&
         attributes[i].type !== 'JSXSpreadAttribute')
     ) {
-      groupCount++;
+      groupCount += 1;
       sortableAttributeGroups[groupCount - 1] = [];
     }
     if (attributes[i].type !== 'JSXSpreadAttribute') {
@@ -342,7 +342,7 @@ module.exports = {
             }
           }
 
-          if (!noSortAlphabetically && previousPropName.localeCompare(currentPropName) > 0) {
+          if (!noSortAlphabetically && previousPropName > currentPropName) {
             context.report({
               node: decl.name,
               message: 'Props should be sorted alphabetically',