refactor to use if statement with early returns.

jsx-eslint · Sep 9, 2020 · b5b8364 · b5b8364
1 parent 411dd9a
commit b5b8364
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/lib/rules/jsx-no-literals.js b/lib/rules/jsx-no-literals.js
@@ -52,28 +52,30 @@ module.exports = {
 
   create(context) {
     const defaults = {
-      noStrings: false, allowedStrings: [], ignoreProps: false, noAttributeStrings: false
+      noStrings: false,
+      allowedStrings: [],
+      ignoreProps: false,
+      noAttributeStrings: false
     };
     const config = Object.assign({}, defaults, context.options[0] || {});
     config.allowedStrings = new Set(config.allowedStrings.map(trimIfString));
 
     function defaultMessage() {
-      switch (true) {
-        case config.noAttributeStrings:
-          return 'Strings not allowed in attributes';
-        case config.noStrings:
-          return 'Strings not allowed in JSX files';
-        default:
-          return 'Missing JSX expression container around literal string';
+      if (config.noAttributeStrings) {
+        return 'Strings not allowed in attributes';
       }
+      if (config.noStrings) {
+        return 'Strings not allowed in JSX files';
+      }
+      return 'Missing JSX expression container around literal string';
     }
 
     function reportLiteralNode(node, customMessage) {
       const errorMessage = customMessage || defaultMessage();
 
       context.report({
         node,
-        message: `${errorMessage}: "${context.getSourceCode().getText(node).trim()}"`
+        message: `${errorMessage}: “${context.getSourceCode().getText(node).trim()}”`
       });
     }