Correct React.createClass defaultProps

jsx-eslint · Feb 24, 2017 · b36e82d · b36e82d
1 parent 0a2abc5
commit b36e82d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/lib/rules/no-invalid-default-props.js b/lib/rules/no-invalid-default-props.js
@@ -584,10 +584,6 @@ module.exports = {
             return;
           }
 
-          if (isDefaultProp && property.value.type === 'ObjectExpression') {
-            addDefaultPropsToComponent(component, getDefaultPropsFromObjectExpression(property.value));
-          }
-
           if (isDefaultProp && property.value.type === 'FunctionExpression') {
             var returnStatement = utils.findReturnStatement(property);
             if (!returnStatement || returnStatement.argument.type !== 'ObjectExpression') {

diff --git a/tests/lib/rules/no-invalid-default-props.js b/tests/lib/rules/no-invalid-default-props.js
@@ -887,15 +887,17 @@ ruleTester.run('no-invalid-default-props', rule, {
         '    foo: React.PropTypes.string,',
         '    bar: React.PropTypes.string.isRequired',
         '  },',
-        '  defaultProps: {',
-        '    baz: "baz"',
+        '  getDefaultProps: function() {',
+        '    return {',
+        '      baz: "baz"',
+        '    };',
         '  }',
         '});'
       ].join('\n'),
       errors: [{
         message: 'defaultProp "baz" has no corresponding propTypes declaration.',
-        line: 10,
-        column: 5
+        line: 11,
+        column: 7
       }]
     },
     {