Merge pull request #1098 from arian/createElement-display-test

Test false positive component detection for destructured createElement
jsx-eslint · Dec 27, 2018 · b33ae84 · b33ae84
2 parents 84be80a + 37e71bb
commit b33ae84
Showing 1 changed file with 42 additions and 0 deletions.
diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -362,6 +362,48 @@ ruleTester.run('display-name', rule, {
       module.exports = someDecorator;
     `,
     parser: 'babel-eslint'
+  }, {
+    code: [
+      'import React, {createElement} from "react";',
+      'const SomeComponent = (props) => {',
+      '  const {foo, bar} = props;',
+      '  return someComponentFactory({',
+      '    onClick: () => foo(bar("x"))',
+      '  });',
+      '};'
+    ].join('\n')
+  }, {
+    code: [
+      'import React, {createElement} from "react";',
+      'const SomeComponent = (props) => {',
+      '  const {foo, bar} = props;',
+      '  return someComponentFactory({',
+      '    onClick: () => foo(bar("x"))',
+      '  });',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint'
+  }, {
+    code: [
+      'import React, {Component} from "react";',
+      'function someDecorator(ComposedComponent) {',
+      '  return class MyDecorator extends Component {',
+      '    render() {return <ComposedComponent {...this.props} />;}',
+      '  };',
+      '}',
+      'module.exports = someDecorator;'
+    ].join('\n')
+  }, {
+    code: [
+      'import React, {Component} from "react";',
+      'function someDecorator(ComposedComponent) {',
+      '  return class MyDecorator extends Component {',
+      '    render() {return <ComposedComponent {...this.props} />;}',
+      '  };',
+      '}',
+      'module.exports = someDecorator;'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }, {
     code: `
       const element = (