remove br tag from list of inline elements, add tests

jsx-eslint · May 18, 2021 · ad2b39d · ad2b39d
1 parent 9aa539d
commit ad2b39d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/rules/jsx-child-element-spacing.js b/lib/rules/jsx-child-element-spacing.js
@@ -3,14 +3,16 @@
 const docsUrl = require('../util/docsUrl');
 
 // This list is taken from https://developer.mozilla.org/en-US/docs/Web/HTML/Inline_elements
+
+// Note: 'br' is not included because whitespace around br tags is
+// inconsequential to the rendered output
 const INLINE_ELEMENTS = new Set([
   'a',
   'abbr',
   'acronym',
   'b',
   'bdo',
   'big',
-  'br',
   'button',
   'cite',
   'code',

diff --git a/tests/lib/rules/jsx-child-element-spacing.js b/tests/lib/rules/jsx-child-element-spacing.js
@@ -139,6 +139,31 @@ ruleTester.run('jsx-child-element-spacing', rule, {
         B
       </App>
     `
+  }, {
+    code: `
+      <App>
+        A
+        <br/>
+        B
+      </App>
+    `
+  }, {
+    code: `
+      <App>
+        A<br/>
+        B
+      </App>
+    `
+  }, {
+    code: `
+      <App>
+        A<br/>B
+      </App>
+    `
+  }, {
+    code: `
+      <App>A<br/>B</App>
+    `
   }],
 
   invalid: [{