[Fix] prop-types: avoid crash when spreading any type

Fixes #2605.
jsx-eslint · Mar 25, 2020 · a93ef20 · a93ef20
1 parent ad18d35
commit a93ef20
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/util/ast.js b/lib/util/ast.js
@@ -155,7 +155,7 @@ function stripQuotes(string) {
  * Retrieve the name of a key node
  * @param {Context} context The AST node with the key.
  * @param {ASTNode} node The AST node with the key.
- * @return {string} the name of the key
+ * @return {string | undefined} the name of the key
  */
 function getKeyValue(context, node) {
   if (node.type === 'ObjectTypeProperty') {
@@ -172,6 +172,9 @@ function getKeyValue(context, node) {
     return;
   }
   const key = node.key || node.argument;
+  if (!key) {
+    return;
+  }
   return key.type === 'Identifier' ? key.name : key.value;
 }
 

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1650,6 +1650,17 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: parsers.BABEL_ESLINT
+    }, {
+      code: `
+        type FooProps = {
+          ...any,
+          ...42,
+        }
+        function Foo(props: FooProps) {
+          return <p />;
+        }
+      `,
+      parser: parsers.BABEL_ESLINT
     }, {
       code: [
         'type Person = {',