fixup! [New] Components.detect tracks React imports

jsx-eslint · Nov 28, 2021 · 8c39df4 · 8c39df4
1 parent ab7dafa
commit 8c39df4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -189,8 +189,8 @@ class Components {
    *
    * @returns {ASTNode} React default import node
    */
-  getDefaultReactImport() {
-    return ReactImports.get(this).defaultReactImport;
+  getDefaultReactImports() {
+    return ReactImports.get(this).defaultReactImports;
   }
 
   /**
@@ -211,7 +211,7 @@ class Components {
   addDefaultReactImport(specifier) {
     const info = ReactImports.get(this);
     ReactImports.set(this, Object.assign({}, info, {
-      defaultReactImport: specifier,
+      defaultReactImports: (info.defaultReactImports || []).concat(specifier),
     }));
   }
 

diff --git a/tests/util/Component.js b/tests/util/Component.js
@@ -77,12 +77,14 @@ describe('Components', () => {
       testComponentsDetect({
         code: 'import React, { useCallback, useState } from \'react\'',
       }, (_context, components) => {
-        const defaultReactImport = components.getDefaultReactImport();
-        assert(defaultReactImport.local.name === 'React', 'default React import identifier should be "React"');
+        assert.deepEqual(
+          components.getDefaultReactImports().map((specifier) => specifier.local.name),
+          ['React'],
+          'default React import identifier should be "React"'
+        );
 
-        const namedReactImports = components.getNamedReactImports();
         assert.deepEqual(
-          namedReactImports.map((specifier) => specifier.local.name),
+          components.getNamedReactImports().map((specifier) => specifier.local.name),
           ['useCallback', 'useState'],
           'named React import identifiers should be "useCallback" and "useState"'
         );