Allow crossOrigin on image tag (SVG) in no-unknown-properties

Fixes #3250
jsx-eslint · Mar 21, 2022 · 683497d · 683497d
1 parent 567bc7d
commit 683497d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/rules/no-unknown-property.js b/lib/rules/no-unknown-property.js
@@ -27,7 +27,8 @@ const DOM_ATTRIBUTE_NAMES = {
 };
 
 const ATTRIBUTE_TAGS_MAP = {
-  crossOrigin: ['script', 'img', 'video', 'audio', 'link'],
+  // image is required for SVG support, all other tags are HTML.
+  crossOrigin: ['script', 'img', 'video', 'audio', 'link', 'image'],
 };
 
 const SVGDOM_ATTRIBUTE_NAMES = {

diff --git a/tests/lib/rules/no-unknown-property.js b/tests/lib/rules/no-unknown-property.js
@@ -53,6 +53,7 @@ ruleTester.run('no-unknown-property', rule, {
     { code: '<script crossOrigin />' },
     { code: '<audio crossOrigin />' },
     { code: '<div hasOwnProperty="should not be allowed tag" />' },
+    { code: '<svg><image crossOrigin /></svg>' },
   ]),
   invalid: parsers.all([
     {
@@ -220,7 +221,7 @@ ruleTester.run('no-unknown-property', rule, {
           data: {
             name: 'crossOrigin',
             tagName: 'div',
-            allowedTags: 'script, img, video, audio, link',
+            allowedTags: 'script, img, video, audio, link, image',
           },
         },
       ],