[Fix] jsx-handler-names: avoid a crash when an inline prop is not a…

… MemberExpression Fixes #2803. Co-authored-by: Will Heslam <willheslam@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
jsx-eslint · Sep 23, 2020 · 67699eb · 67699eb
1 parent 0c412ef
commit 67699eb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 
 ## Unreleased
 
+### Fixed
+* [`jsx-handler-names`]: avoid a crash when an inline prop is not a MemberExpression ([#2803][] @willheslam)
+
+[#2803]: https://github.com/yannickcr/eslint-plugin-react/issues/2803
+
 ## [7.21.0] - 2020.09.22
 
 ### Added

diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -109,7 +109,7 @@ module.exports = {
           || (
             !checkLocal
             && (isInlineHandler(node)
-              ? !node.value.expression.body.callee.object
+              ? !node.value.expression.body.callee || !node.value.expression.body.callee.object
               : !node.value.expression.object
             )
           )

diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js
@@ -70,6 +70,8 @@ ruleTester.run('jsx-handler-names', rule, {
     options: [{
       checkInlineFunction: true
     }]
+  }, {
+    code: '<TestComponent onChange={() => 42} />'
   }, {
     code: '<TestComponent onChange={this.props.onFoo} />'
   }, {