[Refactor] void-dom-elements-no-children: improve performance

jsx-eslint · Apr 28, 2021 · 6437617 · 6437617
1 parent 6cf3812
commit 6437617
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -393,25 +393,29 @@ function componentRule(rule, context) {
      * @returns {Boolean} True if createElement called from pragma
      */
     isCreateElement(node) {
-      const calledOnPragma = (
+      // match `React.createElement()`
+      if (
         node
         && node.callee
         && node.callee.object
         && node.callee.object.name === pragma
         && node.callee.property
         && node.callee.property.name === 'createElement'
-      );
+      ) {
+        return true;
+      }
 
-      const calledDirectly = (
+      // match `createElement()`
+      if (
         node
         && node.callee
         && node.callee.name === 'createElement'
-      );
-
-      if (this.isDestructuredFromPragmaImport('createElement')) {
-        return calledDirectly || calledOnPragma;
+        && this.isDestructuredFromPragmaImport('createElement')
+      ) {
+        return true;
       }
-      return calledOnPragma;
+
+      return false;
     },
 
     /**