🎨 Address review comments

jsx-eslint · Dec 27, 2020 · 5b45d48 · 5b45d48
1 parent 83921d7
commit 5b45d48
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/lib/rules/jsx-embed-condition.js b/lib/rules/jsx-embed-condition.js
@@ -37,8 +37,7 @@ module.exports = {
         }
         context.report({
           node,
-          message:
-            'Using && to condition JSX embeds is forbidden. Convert it to a ternary operation instead'
+          message: 'Using && to condition JSX embeds is forbidden. Convert it to a ternary operation instead'
         });
       }
     };

diff --git a/tests/lib/rules/jsx-embed-condition.js b/tests/lib/rules/jsx-embed-condition.js
@@ -13,7 +13,7 @@ const RuleTester = require('eslint').RuleTester;
 const rule = require('../../../lib/rules/jsx-embed-condition');
 
 const parserOptions = {
-  ecmaVersion: 2018,
+  ecmaVersion: 2020,
   sourceType: 'module',
   ecmaFeatures: {
     jsx: true
@@ -40,13 +40,9 @@ ruleTester.run('jsx-embed-condition', rule, {
     code: '<App>{x ? <div>{y ? <y /> : <z />}</div> : null}</App>'
   }, {
     code: '<App x={x && y}>{x ? <div>{y ? <y /> : <z />}</div> : null}</App>'
-  }
-  // {
-  //   code: '<App test>{x ?? <div />}</App>'
-  // }
-  // TODO: ^ Using above gives a Parsing error in ESLint.
-  // Is the parser out of date
-  ],
+  }, {
+    code: '<App test>{x ?? <div />}</App>'
+  }],
 
   invalid: [{
     code: '<div>{x && <div />}</div>',