[Fix] no-typos: Compilation error when method name is string instea…

…d of identifier
jsx-eslint · Dec 5, 2019 · 4fedc5f · 4fedc5f
1 parent d52002a
commit 4fedc5f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/no-typos.js b/lib/rules/no-typos.js
@@ -144,7 +144,11 @@ module.exports = {
 
     function reportErrorIfLifecycleMethodCasingTypo(node) {
       LIFECYCLE_METHODS.forEach((method) => {
-        if (method.toLowerCase() === node.key.name.toLowerCase() && method !== node.key.name) {
+        let nodeKeyName = node.key.name;
+        if (node.key.type === 'Literal') {
+          nodeKeyName = node.key.value;
+        }
+        if (method.toLowerCase() === nodeKeyName.toLowerCase() && method !== nodeKeyName) {
           context.report({
             node,
             message: 'Typo in component lifecycle method declaration'

diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js
@@ -203,6 +203,14 @@ ruleTester.run('no-typos', rule, {
       }
     `,
     parserOptions
+  }, {
+    code: `
+      class Hello extends React.Component {
+        "componentDidMount"() { }
+        "my-method"() { }
+      }
+    `,
+    parserOptions
   }, {
     code: `
       class MyClass {