Skip to content

Commit

Permalink
Merge pull request #1530 from backjo/deprecatedFactory
Browse files Browse the repository at this point in the history
Deprecation check for React.DOM factories
  • Loading branch information
ljharb committed Nov 11, 2017
2 parents dea04b6 + 640632e commit 4f3fc51
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docs/rules/no-deprecated.md
Expand Up @@ -23,6 +23,9 @@ const propTypes = {
foo: PropTypes.bar,
};

//Any factories under React.DOM
React.DOM.div();

import React, { PropTypes } from 'react';
```

Expand Down
3 changes: 2 additions & 1 deletion lib/rules/no-deprecated.js
Expand Up @@ -68,7 +68,8 @@ module.exports = {
// 15.5.0
deprecated[`${pragma}.createClass`] = ['15.5.0', 'the npm module create-react-class'];
deprecated[`${pragma}.PropTypes`] = ['15.5.0', 'the npm module prop-types'];

// 15.6.0
deprecated[`${pragma}.DOM`] = ['15.6.0', 'the npm module react-dom-factories'];
return deprecated;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/lib/rules/no-deprecated.js
Expand Up @@ -174,5 +174,11 @@ ruleTester.run('no-deprecated', rule, {
errors: [{
message: 'ReactPerf.printDOM is deprecated since React 15.0.0, use ReactPerf.printOperations instead'
}]
},
{
code: 'React.DOM.div',
errors: [{
message: 'React.DOM is deprecated since React 15.6.0, use the npm module react-dom-factories instead'
}]
}]
});

0 comments on commit 4f3fc51

Please sign in to comment.