fix: remove error reporting for empty string for react >=v18

jsx-eslint · Nov 14, 2022 · 3dd1215 · 3dd1215
1 parent 6073df0
commit 3dd1215
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/rules/jsx-no-leaked-render.js b/lib/rules/jsx-no-leaked-render.js
@@ -7,6 +7,7 @@
 
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
+const { testReactVersion } = require('../util/version');
 const isParenthesized = require('../util/ast').isParenthesized;
 
 //------------------------------------------------------------------------------
@@ -129,13 +130,14 @@ module.exports = {
             return;
           }
         }
-
-        report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', {
-          node,
-          fix(fixer) {
-            return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right);
-          },
-        });
+        if(!testReactVersion(context, '>= 18.0.0') && !(node.left.value == '')){
+            report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', {
+            node,
+            fix(fixer) {
+                return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right);
+            },
+          });
+        }
       },
 
       'JSXExpressionContainer > ConditionalExpression'(node) {

diff --git a/tests/lib/rules/jsx-no-leaked-render.js b/tests/lib/rules/jsx-no-leaked-render.js
@@ -232,7 +232,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
         return (
           <>
             {0 ? <Something/> : null}
-            {'' ? <Something/> : null}
+            {'' && <Something/>}
             {NaN ? <Something/> : null}
           </>
         )