[Fix] jsx-indent: avoid a crash on non-string literals

Fixes #2561.
jsx-eslint · Feb 2, 2020 · 3da6eb3 · 3da6eb3
1 parent 000d6b8
commit 3da6eb3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -306,7 +306,7 @@ module.exports = {
       const value = node.value;
       const regExp = indentType === 'space' ? /\n( *)[\t ]*\S/g : /\n(\t*)[\t ]*\S/g;
       const nodeIndentsPerLine = Array.from(
-        matchAll(value, regExp),
+        matchAll(String(value), regExp),
         match => (match[1] ? match[1].length : 0)
       );
       const hasFirstInLineNode = nodeIndentsPerLine.length > 0;

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -976,6 +976,19 @@ const Component = () => (
       '</App>'
     ].join('\n'),
     options: ['tab']
+  }, {
+    code: [
+      '<App>',
+      '\t{undefined}',
+      '\t{null}',
+      '\t{true}',
+      '\t{false}',
+      '\t{42}',
+      '\t{NaN}',
+      '\t{"foo"}',
+      '</App>'
+    ].join('\n'),
+    options: ['tab']
   }],
 
   invalid: [{